[PATCH] Konqueror AdBlocK v5

[Leo Savernik]

Am Sonntag, 1. Mai 2005 21:07 schrieb Ivor Hewitt:
> Ok, by that do you mean that I'm currently setting them in the wrong
> kcontrol config module?

I haven't looked at your kcontrol code. If your changes take effect, chances 
are that you did it right ;-)
>
> > My point was that if a special app wants to make special use of khtml
> > (including setting filters), those settings should not pollute the global
> > config file. That's why KHTMLSettings::addAdFilter must not write to the
> > config file directly.
>
> But aren't users going to expect that when they right click on an image and
> say "Block" they would expect that to be added to the global block
> settings?

Sure, in konqueror, they will. However, special apps will very likely provide 
their own context menu (see KMail).

But now I understand your point. You need the addAdFilter to make the "Block 
this image" context menu entry work. Hmm, in this case I suggest that you do 
write into the global config if and only if KHTMLPart::GUIProfile == 
KHTMLPart::BrowserViewGUI.

mfg
	Leo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20050501/928bd484/attachment.sig>