Patch: fix intermittent crash in KHTML Thai Word Break

Pattara Kiatisevi ott-list at thaigate.nii.ac.jp
Mon Mar 21 07:52:56 GMT 2005


On Thursday 17 March 2005 18:30, Germain Garand wrote:
> Le jeudi 17 Mars 2005 09:01, Pattara Kiatisevi a écrit :
> > Hmm.. I just downloaded kdelibs-3.4.0.tar.bz2 and still found:
> >
> >     void cleanup_thaibreaks()
> >     {
> >         delete cache;
> >     }
> >
> > without the two lines that fix the problem.
> > +       cache = 0;
> > +       th_brk = 0;
>
> yeah, this was commited to head a couple of days before the
> "KDE_3_4_0_RELEASE tag is set to final" mail arrived.
> I didn't expected it that soon ;(
> Will backport for 3.4.1 today along with a bunch of other
> crash/regression fixes.

I see, thank you very much. By the way I think there should be a 
little modification. Otherwise it won't compile in case of 
"./configure --enable-libthai=yes" case.

[...]

    void cleanup_thaibreaks()
    {
        delete cache;
        cache = 0;
#ifndef HAVE_LIBTHAI
        th_brk = 0;
#endif
    }

[...]

What do you think?
Pattara

>
> Greetings,
> Germain




More information about the kfm-devel mailing list