Patch: fix intermittent crash in KHTML Thai Word Break

Pattara Kiatisevi ott-list at thaigate.nii.ac.jp
Thu Mar 17 09:01:44 GMT 2005


On Wednesday 02 March 2005 03:43, Germain Garand wrote:
> Le mardi 01 Mars 2005 16:43, Pattara Kiatisevi a écrit :
> > Dear Germain,
> >
> > Yes I changed the code as you suggested (please see the attached
> > patch) and tested. So far it works fine. No crash.
>
> good, I commited then... let us know if you have further issues.

Hmm.. I just downloaded kdelibs-3.4.0.tar.bz2 and still found:

    void cleanup_thaibreaks()
    {
        delete cache;
    }

without the two lines that fix the problem.
+       cache = 0;
+       th_brk = 0;

Cheers,
Pattara

>
> > This is new to me, I thought "delete x" means "free the memory
> > that x is pointing to and set x to 0", hmm.
>
> and take all the double deletion fun out of C++? no way! :)
>
> Greetings,
> Germain




More information about the kfm-devel mailing list