Fwd: Bug 96184

[Aaron J. Seigo]

forwarding this on to the appropriate mailing list. =)

----------  Forwarded Message  ----------

Subject: Bug 96184
Date: Wednesday 09 March 2005 05:35
From: mweilguni at kde.org
To: kde-devel at mail.kde.org
Cc: konq-bugs at kde.org

hi,

this bug crashes konqueror when javascript is disabled, but a
window.setTimeout or setInterval calls a javascript function after
deactivion.

This patch fixes it, but I don't want to apply it before one of the konqueror
developers can take a look on it:

Index: kjs_window.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/ecma/kjs_window.cpp,v
retrieving revision 1.396
diff -r1.396 kjs_window.cpp
1913,1914c1913,1920
<     if (parent->part())
<       action->execute(parent);
---

>     if (parent->part()) {
>       KHTMLPart *_part = ::qt_cast<KHTMLPart *>(parent->part());
>       if(_part->jScriptEnabled())
>         action->execute(parent);
>         else
>           // Javascript was disabled, don't start again
>           scheduledActions.removeRef(action);
>     }

Mario

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
>> <<

-------------------------------------------------------

-- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20050309/a584e346/attachment.sig>