(not) Adding a statusbar widget

[Koos Vriezen]

On Thu, Jun 02, 2005 at 10:18:15PM +0200, David Faure wrote:
> On Thursday 02 June 2005 21:50, Koos Vriezen wrote:
> > On Thu, Jun 02, 2005 at 08:59:49PM +0200, Koos Vriezen wrote:
> > > Anyhow, it works :-).  Commit it?
> > 
> > Well almost everything but the kjas part :-(. Context idea sucks I'm
> > afraid. So updated for each applet an icon ..
> 
> The khtml_part patch looks fine - thanks for that fix.
> Don't know the javaapplet code, but the statusbar-extension usage looks ok to me.

Hmm, what if I move the code added outside this if/else clause?

Index: khtml_part.cpp
===================================================================
--- khtml_part.cpp      (revision 421260)
+++ khtml_part.cpp      (working copy)
@@ -4393,6 +4403,9 @@
     if (::qt_cast<KHTMLPart*>(part)) {
       static_cast<KHTMLPart*>(part)->d->m_frame = child;
     } else if (child->m_frame) {
+      KParts::StatusBarExtension *sb =
KParts::StatusBarExtension::childObject(part);
+      if (sb)
+          sb->setStatusBar( d->m_statusBarExtension->statusBar() );

It makes applets in frames work, but I can't fully oversee what will
happen with the wallet/ssl/UA icons. Ie. will one of these show at all
if only one of the framesets has that particular feature? And, otoh,
what in this proposed case will happen if both parent and child frame
have one of this.
>From a litle test I've done with a frameset having a frame with a https
SRC, w/ or w/o this suggested change, the ssl icon does show up once.
And when clicked it says 'Some of this document is secured with SSL, but
the main part is not'.
Another test with a frameset, having two frames with a UA, I only see
one icon w/ or w/o this change. This icon is nothing more than a picture
it seems.
So, from this limited test, it looks ok to move outside the if/else. But
I can't see why this already worked before ... what do I miss?

Koos