[PATCH] Ad blocking with instant effect

[Ivor Hewitt]

Thiago Macieira wrote:
> Andreas Kling wrote:
> 
>>The attached patch will modify the KHTML ad blocker to have instant
>>effect when adding/removing filters. In other words, all matching IMG
>>and IFRAME elements will go away when adding a new filter, and if you
>>remove it, they will pop back.
>>
>>This only applies to new filters. Elements that were filtered on page
>>load will not return when removing the corresponding filter. (Until the
>>page is reloaded, of course.)
> 
> 
> That's a nice idea. Thanks for implementing it!
> 
> But I fear it may be confusing: some filters have immediate effect, some 
> don't. I'd rather have the Apply button re-apply all filters again if 
> possible.
> 
> In order to refilter, does khtml require a reload from network?
> 
Thiago,
In practice I don't think it will be confusing really. The only case 
they won't reappear is when you open a page that has preexisting 
filtered ads and you then remove and reapply the filters. The user won't 
see any visual difference on the one page they're looking at, but then 
they wouldn't have known that there were filtered ads there in the first 
place. Most users wouldn't be doing this, and if they were they would 
probably assume that they had to hit refresh to get the ads loaded.

On the other hand the most typical case which I think will work would be 
someone clicks on an image to filter it.... all the images on the page 
disappear, they think "doh" go into the filters page, remove the filter 
and ping, the images reappear.

That's my take on it anyway.

Cheers,

-- 
Ivor
http://www.ivor.it