dead code in KHTMLPart::htmlError
David Faure
faure at kde.org
Wed Jan 19 11:01:36 GMT 2005
On Wednesday 05 January 2005 16:45, Leo Savernik wrote:
> I've just found this snippet of dead code in KHTMLPart::htmlError:
>
> ...
> emit completed();
> return;
> // following disabled until 3.1
>
> QString errorName, techName, description;
> QStringList causes, solutions;
>
> QByteArray raw = KIO::rawErrorDetail( errorCode, text, &reqUrl );
> QDataStream stream(raw, IO_ReadOnly);
>
> stream >> errorName >> techName >> description >> causes >> solutions;
> ...
>
> This is the status as of KDE_3_3_BRANCH, and HEAD as well.
>
> My question: Has this been forgotten? Or has this code been superseded and can
> safely be deleted?
The author (use cvs ann to find his name again, Hamish Rodda iirc?) had no time to come back
and enable it. But I guess the initial idea remains, that this code should give
better error messages to users. So you might want to try and enable it, see if
it still works :)
--
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
More information about the kfm-devel
mailing list