bookmarkbar/menu support for Ctrl+Left, NewTabInFront

[Matt Rogers]

On Sunday 16 January 2005 10:05 pm, Daniel Teske wrote:
> Hi
>
> these patches correct the behauviour of the bookmarbar/menu.
> This complements the already applied patch, that added support for MMB
> clicking to the bookmarkbar/menu.
>
> The patches add:
> Support for Ctrl+Left clicks, which always open in a new tab.
> MMB clicks open new windows if MMBOpensTab is false.
> New Tabs respect the NewTabInFront setting, SHIFT can be used to negate
> that.
> (Thanks Leo for explaining all the details.)
>
> daniel

the kio/bookmarks changes look ok. However, i would prefer you just connect 
the signal from the menu straight into another signal rather than creating a 
slot that just emits the new signal, especially since the signatures are the 
same. (i'm not the maintainer of that code, i'm just one of the people who 
touched it last, IIRC, so i'm exercising some creative liberties. :) )

For example, you have:

connect(menu, SIGNAL( openBookmark( const QString &, Qt::ButtonState) ),
	this, SLOT( slotOpenBookmarkURL( const QString &, Qt::ButtonState) ));

when something like:

connect(menu, SIGNAL( openBookmark( const QString &, Qt::ButtonState) ),
	this, SIGNAL( openBookmarkURL( const QString &, Qt::ButtonState) ));

would be preferable from my point of view. 


I won't comment on the konq-ctrl.patch since i don't know anything about that 
code.

Thanks,
Matt