[patch] to bug 88243

[Koos Vriezen]

On Fri, Feb 11, 2005 at 01:51:21AM +0100, Koos Vriezen wrote:
> On Fri, Feb 11, 2005 at 01:42:22AM +0100, Paul Temple wrote:
> > David Faure wrote:
> > > The bug number is wrong - 88243 is "Desktop sharing fails with
> > > diskless X terminals".... Ah, you meant 82243.
> > 
> > Thanks... I'll check the number once again before committing :)
> > 
> > > Oh. Final patch looks good.
> > > As Koos said, I would check for handle() not being null
> > > though.
> > 
> > Then it's OK committing the attached patch?
> > 
> > C++ checks the "if (x && y)" from left to right (like Java does), 
> > right?
> 
> Yes, like java lazy from left to right.
> 
> One nitpick though, why do you declare
>   Value gdNode = getDOMNode(exec,node.appendChild(myNode));
> and only use it for the return. Why not
>   return getDOMNode(exec,node.appendChild(myNode));
> ? That saves one Value construction.

Agh, how silly of me. That does the appending of course. Ignore my
nitpick

Koos