[patch] to bug 88243
Koos Vriezen
koos.vriezen at xs4all.nl
Fri Feb 11 00:56:45 GMT 2005
On Fri, Feb 11, 2005 at 01:55:12AM +0100, Paul Temple wrote:
> Koos Vriezen wrote:
> > One nitpick though, why do you declare
> > Value gdNode = getDOMNode(exec,node.appendChild(myNode));
> > and only use it for the return. Why not
> > return getDOMNode(exec,node.appendChild(myNode));
> > ? That saves one Value construction.
>
> I wanted to close that thing _after_ adding it, just to be safe.
> The khtml gurus can probably tell me if this is really
> necessary.
Sorry my fault, this is correct. It would definitly be wrong to close it
before attaching.
Koos
More information about the kfm-devel
mailing list