[PATCH] Bugfixes for profiles and preloading.

[Emanuele Tamponi]

On Friday 23 December 2005 10:09, David Faure wrote:
> > http://principe.homelinux.net/patch/
>
> I get a timeout, so I can't read that page.

The timeout was because I turned off my pc... Now it's online until 
midnight... Excuse me for the inconvenience, I'm upgrading my real server.

>
> +           KonqMainWindow::preloadedWindow()->xmlFile() == (new
> KConfig(path))->readEntry("XMLUIFile") ) This one is even a memory leak,
> the KConfig isn't deleted.
>
> Maybe a solution is to let KonqMainWindow keep around a KConfig* pointing
> to the current profile.

Oh... I didn't notice the memory leak, excuse me...
The idea of keeping a KConfig member was nice to me too, I'll edit the 
patch :)

> Also I wonder why dk->autoSaveGroup is used for saving but not for loading.
>
> Hmm, don't you have to remove the old code that read the window size from
> the profile?

the *dk member was necessary... because I needed something to store some 
options... but I can also remove the dk and put all the variables in separate 
members! However, KonqMainWindowPrivate has been written quickly so I'll 
modify it too...

About window size, I'm looking for that code.

> Thanks for your contribution.

Thanks to you for your attention.
Emanuele