[PATCH] Support for POSIX ACL in kioslave/file and kio/kio

[Thiago Macieira]

Till Adam wrote:
>Heya folks,
>
>please find attached two patches, one against kdelibs/kioslave/file and
> one against kdelibs/kio, which together implement support for managing
> POSIX ACLs on filesystems that support it. Please review, I'll then
> merge this into 3.5.

Thanks, Till, it's great work.

>Limitations/TODO:
> o it currently only works for a single file (no support for "partial"
>   handling), that's the next thing I'd like to tackle once this is in

Do you plan on having an interface to set the ACLs on "this dir, all files 
and dirs beneath it"?

> o the users and groups are offered as comboboxes, which has scalability
>   issues, I'm planing to offer a lineedit with completion when the
> number of available users/groups exceeds a certain limit

I recommend here a standard widget for selecting users and groups, like 
kaddressbook integration in KMail's composer -- in fact, kabc could 
integrate with it too -- but outside libkabc.

This kind of widget in libkdeui could be useful for other applications as 
well as the standard properties dialog (think chgrp).

> o the configure checks aren't done yet, I guess this needs to be a
> compile time option

I'll help you here. But I'll need you to tell me how the KACL class will 
behave when the support for it isn't present. It must exist and be BC to 
the working version.

The same goes for kacl.h: it should be installed regardless of the support 
being actually compiled in.

>I'd be grateful for any testing and feedback that you might be able to
> spare.

I don't have any filesystems with ACL support, so I can't help you 
actually test the code, but I can at least make sure it won't break what 
existed before :-)

Why does the copy constructor for KACL parse the rhs's string 
representation? Can't it copy the parsed data?

Don't we have a standard class for representing and fetching system users 
(I'm thinking of KACL::getUserName and KACL::getGroupName)? If we don't, 
we should.

BTW, thanks for fixing the setuid/setgid/vtx flags in kio_file. I had 
never noticed them to be wrong, not even when I fixed the same thing in 
kio_ftp

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

2. Tó cennan his weorc gearu, ymbe se circolwyrde, wearð se cægbord and se 
leohtspeccabord, and þa mýs cómon lator. On þone dæg, he hine reste.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20050807/fbb36ccd/attachment.sig>