[PATCH] Konqueror adblock v4

[David Faure]

On Saturday 30 April 2005 23:17, Ivor Hewitt wrote:
> Latest version attached.

d->m_imageURL.host() != QString::null 
is usually written as !d->m_imageURL.host().isEmpty(), which is slightly faster.

Marc Mutz would also say: use QValueVector instead of QValueList, 
takes less memory - no need for two pointers (prev/next) for each regexp.
In this case a reserve() can even be done before the loop that calls append().
But I can make this change myself once the patch is in, if you want.

isKillEnabled() could have a more self-describing name. Think of someone reading
the KHTML source code without having followed this thread, how could he guess
what "killing" is about here? :)
Not that I have anything to suggest; isRemoveFilteredEnabled is a bit long :)

m_wasBlocked=1;
should be true instead 1, it's a boolean.

Can't comment on the rendering/loader part of the patch.

Thanks!

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).