[PATCH] Konqueror adblock v3

Ivor Hewitt ivor at ivor.org
Fri Apr 29 16:51:06 BST 2005


> Am Donnerstag, 28. April 2005 21:51 schrieb Ivor Hewitt:
>> Version 3....
>>
>> This simply fixes the config change not updating and attempts to strip
>> iframes that match too.
>
> Yes! Including the hints David gave you, it seems right for commit (as far as
> the khtml-changes are concerned).
>
I'll make another patch this evening which includes David's corrections and
which adds an additional "Block Image" option to the context menu if filters
are enabled.

>>
>> I can't find a nice way to strip the images so they don't retain their
>> sizes though.  I tried single pixel transparent image, but it still left a
>> gap the size of the stripped image.
>
> You can't.
> If a page specifies, e. g.
> <img
> src="http://verynastyadserver.com/ads/verynastybannerthatflashesandjumps.gif"
> width=400 height=50>
> khtml will allocate a 400x50 pixel space for this image, regardless of what
> will effectively be displayed there.
>
Oh ok. I wondered if there was anyway to tell the renderer that an image had
changed size and that it should re-flow the page.

You're right about it possibly breaking layout - although often you find that
removing the ads in Firefox actually leaves you with a much nicer layout!

Cheers,
Ivor.







More information about the kfm-devel mailing list