[PATCH] Konqueror adblock

Ivor Hewitt ivor at ivor.org
Wed Apr 27 15:46:29 BST 2005


> Am Dienstag, 26. April 2005 23:06 schrieb Ivor Hewitt:
>> Basically I hold a list of url regexes that are then checked against
>> requests for external scripts or images in kdelibs/khtml/misc/loader.cpp.
>
> This solution is slow. Hence I request you inflict a small speedup by
> precompiling the regexps and store them in the khtml_settings instead of
> recompile them from scratch every time in the comparsion loop.
>
Indeed you are right, I was leaving optimisation to the end of my todo list.
Is that simply a matter of holding a list of generated regex objects?

> Luckily, if you don't define any regexps, the loading speed is nearly
> undiminished. So this patch is acceptable from the khtml side.
>
> Please apply said optimisation and post the revised patch to this list.
>
I'll have another version this evening.

Many thanks,
Ivor





More information about the kfm-devel mailing list