shortcuts for type ahead find and find previous + find for find previous

[Lubos Lunak]

On Tuesday 05 of April 2005 17:54, David Faure wrote:
> On Tuesday 05 April 2005 14:53, Lubos Lunak wrote:
> >  Hello,
> >
> >  I'd like to commit the attached patches that make the shortcuts for type
> > ahead find configurable (because / and ' are not very usable e.g. in
> > lineedits) and add action for 'Find Previous' (#87130). Additionally the
> > find previous action needs a couple of fixes for the search code. Ok to
> > commit? The Edit menu gets even a bit bigger with 3 more items, but I
> > think it's still ok.
>
> -  bool findTextNext();
> +  bool findTextNext( bool reverse = false );
>
> This looks like a BIC to me - the method is public.

 Oopsie. How lame of me indeed. Will fix that in the patch.

>
> +    int tmp2 = d->m_findPosEnd;
> +    d->m_findPosEnd = d->m_findPosStart;
> +    d->m_findPosStart = tmp2;
> qSwap( d->m_findPosEnd, d->m_findPosStart ) ?

 I knew there had to be something better :).

>
> Thanks for the fixes for "find previous" - tricky stuff indeed.

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/