[PATCH] Set more appropriate caption for images

[David Faure]

On Monday 25 October 2004 15:14, George Staikos wrote:
> 
> I have a patch that does two related things:
> 1) Introduces a concept of a suggested title for images (which ideally can 
> later make use of image metadata, but presently defaults to the 
> content-disposition filename)
> 2) Takes that title and places it in the caption if KHTML is pointing at an 
> image file directly and it is non-empty
> 
> Any thoughts on this?  I think it's more useful to have the filename there, 
> and I think it would be really cool to be able to make use of metadata.

The patch reads funny since right now the filename and the title are set the same way.
If the metadata thing isn't implemented (you mean reading the JPEG or PNG headers?),
then I would either collapse into one method, or at least add a comment in Loader::slotFinished....
Otherwise anyone not having read this mail, will wonder why have two members
that do exactly the same.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).