gmail problem investigated: frame onload

David Faure faure at kde.org
Mon Oct 4 18:46:16 BST 2004


On Monday 04 October 2004 18:53, Allan Sandfeld Jensen wrote:
> I've been looking at how Safari handles it, and have come up with the attached 
> patch. It works on your test example, but I do not have a gmail-account to 
> test with.

Ouch. Obviously if I choose one way to fix it, they chose another way and didn't send us a patch...

But comparing the two, I really prefer my approach.
Their patch is adding a hack to dispatchWindowEvent itself, and DocumentImpl::ownerElement()
looks awful since it has to navigate through 6 classes [and might not work with Koos' ChildFrame changes].
I was missing something like ownerElement() though, when looking for a way to
fix the bug, but I think the signal/slot solution is much cleaner.

What do other people think?

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kfm-devel mailing list