[PATCH] [Bug 91955] Bidi algorithm: incorrect implementation of rule N2
Stephan Kulow
coolo at kde.org
Thu Nov 4 14:20:55 GMT 2004
Am Thursday 04 November 2004 00:46 schrieb Mitz Pettel:
> On Nov 3, 2004, at 10:20 PM, Stephan Kulow wrote:
>
> > Am Mittwoch 03 November 2004 17:21 schrieb Mitz Pettel:
> >> I see. I think changing line 859 from
> >> if( bidi.status.eor != QChar::DirL ) {
> >> to
> >> if( bidi.status.eor != QChar::DirL &&
> >> bidi.status.eor!=QChar::DirEN ) {
> >> should take care of most of these.
> >
> > I will try tomorrow. Thanks for the fix.
>
> Forget it. I tried it myself and it failed one of the test cases.
> Here's the latest revision of the patch. This one looks good on
> bidi.html, and should not generate excessive runs (however I didn't
> test that part).
Hi!
I get two failures in test cases and two fixes (I listed this morning).
See yourself at http://ktown.kde.org/~coolo/regression/output.bidi/
(the RP are the ones with visible changes)
There is a selector test case that fails now where I can hardly believe
it's the fault of this patch.
Greetings, Stephan
More information about the kfm-devel
mailing list