[PATCH] [Bug 91955] Bidi algorithm: incorrect implementation of rule N2

Mitz Pettel bugs.kde.org at mitzpettel.com
Tue Nov 2 23:17:13 GMT 2004


Hi,

Stephan Kulow has suggested that I post here.

Attached is a proposed patch for kdelibs/khtml/rendering/bidi.cpp to 
resolve bug 91955 (incorrect implementation of rule N2 of the Unicode 
bidi algorithm).

I cleaned up the code at two places in bidiReorderLine, then I 
corrected the issue in the dirCurrent==[AL|R], 
bidi.status.last==[ET|ES|CS|BN|B|S|WS|ON] case, then I adapted the same 
logic to the dirCurrent==L, bidi.status.last==[ET|ES|CS|BN|B|S|WS|ON] 
case. Also set dir and status.eor after the appendRun in the 
dirCurrent==L, bidi.status.last==[R|AL|EN|AN] case, for consistency and 
clarity.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: bidi.cpp.diff
Type: application/octet-stream
Size: 4102 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20041103/a7b22fa2/attachment.obj>
-------------- next part --------------


-- Mitz Pettel


More information about the kfm-devel mailing list