[PATCH] Spring loading folder behaviour (redux)

[Kévin 'ervin' Ottens]

Le jeudi 20 Mai 2004 23:20, Kévin 'ervin' Ottens a écrit :
> David Faure a dit :
> > One thing I noticed: you use static objects, which is not allowed in
> > libraries and loadable modules. One has to use KStaticDeleter instead.
>
> I wasn't aware of this... I'll take a look to this.

From what I've understood KStaticDeleter is obviously for static pointers. I 
was not using pointers... is it still disallowed?

Morevoer I've not found where it is stated that static objects are not 
allowed.

> > I think it would be cleaner to define a new class, make it a singleton
> > and access it from all the iconviews. But since I'm a bit confused about
> > what this feature is about, I could be wrong.
>
> It sounds like a good idea to group the needed objects, maybe some code
> can sit in a separate class too. I'll try to see what can be done in this
> area.

I've worked on it this night. It still works here, nothing seems noticeable 
from the user point of view. But internally it's far better IMHO, only one 
view is notified when the drag'n'drop is finished, etc.
The new class contains almost all the logic.

The new patch for kdebase/konqueror/iconview is attached. It completely 
replace the old one.

Thanks David for this advice! I really don't know why I didn't think of this 
one earlier...

Regards.
-- 
Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: konq_iconview.patch2
Type: text/x-diff
Size: 8118 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20040523/b57cec5f/attachment.diff>