key navigation and visible area of the page

[Lubos Lunak]

Dne út 18. května 2004 22:23 Tobias Anton napsal(a):
> On Dienstag, 18. Mai 2004 10:17, Lubos Lunak wrote:
> >  I would, if you show me that right way. Open the attached page in your
> > Konqy and press accesskeys 9 or 0 (i.e. Ctrl+Alt+9/0). With
> > ensureVisible() the results are (in some cases noticeably) worse.
>
> Index: khtmlview.cpp
> ===================================================================
> RCS file: /home/kde/kdelibs/khtml/khtmlview.cpp,v
> retrieving revision 1.634
> diff -u -3 -p -u -w -B -r1.634 khtmlview.cpp
> --- khtmlview.cpp       17 May 2004 20:24:28 -0000      1.634
> +++ khtmlview.cpp       18 May 2004 21:21:47 -0000
> @@ -1803,8 +1803,8 @@ bool KHTMLView::focusNodeWithAccessKey(
>      }
>  #endif // KHTML_NO_CARET
>
> -    if (!scrollTo(node->getRect()))
> -       return true;
> +    ensureVisible(node->getRect().right(), node->getRect().bottom());
> +    ensureVisible(node->getRect().left(), node->getRect().top());
>
>      Node guard( node );
>      if( node->isSelectable()) {
>
> How is this worse?

 Ok, the idea to do two ensureVisible() calls didn't occur to me. I'll revert 
the scrollTo() changes then.

-- 
 Lubos Lunak
 KDE Developer