[PATCH] kcookiejar

[Waldo Bastian]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thu May 20 2004 21:57, Ralf Holzer wrote:
> Attached is a one-liner that fixes Bug 80501.
>
> extractDomains() in kcookiejar.cpp adds each domain twice, with and without
> the leading '.' (line 653).

Yes, one is for the host, one is for the subdomain.

> But loadConfig() only sets the domain-specific 
> advice for the domain without the prepended dot. 

That depends on the configuration I would think.

> This causes findCookie() 
> to skip over the cookie, because the advice is set to KCookieDunno (line
> 348).

?? Why would it skip over the cookie when the advice is KCookieDunno? When the 
advice is KCookieDunno it will look at the next domain to see if that 
specifies a policy.

> Let me know if there is anything wrong with this approach, otherwise I'll
> commit it.

I'm not convinced that it is correct and if it is than there is probably a 
better way to do it.

Can you post the relevant section of your kcookiejarrc file and say on which 
particular URLs you experience the problem you mention in BR80501?

Cheers,
Waldo
- -- 
bastian at kde.org  |   Novell BrainShare Europe 2004   |  bastian at suse.com
bastian at kde.org  | 12-18 September, Barcelona, Spain |  bastian at suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQFArRdTN4pvrENfboIRAszaAJ97ib3rkVt7Xq2wa+YTFrJWBWX5FQCfTIAz
dirmP0+hPnpHkrNiYPUJMD4=
=+LjD
-----END PGP SIGNATURE-----