[PATCH] Spring loading folder behaviour

[David Faure]

On Thursday 20 May 2004 11:59, Kévin 'ervin' Ottens wrote:
> Hello everybody,
> 
> I've made some patches for kdeui and konqueror too implement
> a spring loading folder feature in konqueror iconview. The original idea
> is from Aaron Seigo and he mentored me.
> 
> AFAIK, spring loading folder is (was?) used in MacOS.

What is "spring loading folder"?

Is that the feature where hovering on top of a folder during a drag-and-drop
operation opens that folder?

> konq_iconviewwidget.patch, should be applied in kdebase/libkonq (modify 
> KonqIconViewWidget)
> konq_iconview.patch, should be applied in kdebase/konqueror/iconview (modify 
> KonqKfmIconView)

The patches look mostly good.
One thing I noticed: you use static objects, which is not allowed in
libraries and loadable modules. One has to use KStaticDeleter instead.
But what's the point of the static list of parts? It looks strange and potentially
dangerous to me. What about the static QTimer? Hmm, all iconviews
need to be notified? All of this is only used during a drag-and-drop, right?

I think it would be cleaner to define a new class, make it a singleton
and access it from all the iconviews. But since I'm a bit confused about what
this feature is about, I could be wrong.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).