[PATCH]KonqIconViewWidget speedup

Enrico Ros eros.kde at email.it
Fri May 7 17:56:09 BST 2004


 
 
 --
 Email.it, the professional e-mail, gratis per te: http://www.email.it/f
 
 Sponsor:
 
 Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=&d=7-5
Hi, I'm posting the patch here because I'm not so confident with 
KonqIconViewWidget but I spotted a performance problem.

When the mouse is moved over this widget (the Desktop itself for example!) a 
check is performed on each movement and that check is so slow.

I'm also thinking at binary compatibility due to a new virtual function added 
to konq_sound's classes. Are problems raised by this patch?

The following tests are performed @ 300 MHz, but you can notice wasted cpu 
cycles even @ GHz! The values are the % of the used cpu for that operation.Mouse movement over a blank widget: 28%Mouse movement over a KIView widget WITHOUT patch: 67%Mouse movement over a KIView widget WITH patch: 37%---------KIView relative load WITH patch: 9%KIView relative load WITHOUT patch: 39%Relative speed gain in KIView with patch applied: ~4x

This is because the QApplication::widgetAt( .. ) static call is very 
expensive. Fortunately this check is needed only when the sound is playing so 
I added a simple check.

Bye
--Enrico
-------------- next part --------------
A non-text attachment was scrubbed...
Name: konq_iconviewwidget_speedup.diff
Type: text/x-diff
Size: 2650 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20040507/735fa58c/attachment.diff>


More information about the kfm-devel mailing list