[PATCH] konqueror --select and bugfixes for #32621, #36219, and #65420.

David Faure faure at kde.org
Mon May 3 08:03:54 BST 2004


On Monday 03 May 2004 04:12, Matt Newell wrote:
> This patch implements konqueror --select and 
> KonquerorIface::openNewWindowWithSelection.
> 
> I haven't added an option to kfmclient yet, but I probably won't have time to 
> do so for a week or so.
> 
> It also fixes bugs #32621, #36219, and #65420.
> These bugs are about losing selections when switching views or when refreshing 
> the current view.

Looks good.
I just wonder why the m_bHasItemsToSelect bool, since it's equivalent to
!m_itemsToSelect.isEmpty() (which is fast)
Other than that, this looks OK. Should I commit it or should I create a CVS
account for you, in case you plan to do more KDE work after that?
(If you choose the latter, see http://developer.kde.org/documentation/other/developer-faq.html#q1.8 )

Thanks,
David.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kfm-devel mailing list