[Bug 67140] Icons placing is a nightmare (fwd)

[David Faure]

On Monday 08 March 2004 19:37, Henry W. Miller wrote:
> Note that this is two completely seperate patches, and not a single two
> part patch.  Apply only one or the other.  Applying both will result in
> the same problem, but in reverse.

The first patch (turning offset into 0,0) looks good to me (after testing).
(I didn't test the other solution though).

> konq_iconviewwidget.patch fixes the root cause, but I can't imangine
> someone writing the code that I basicly backed out for no reason so I
> don't recomend it, I'm sure IT WILL BREAK SOMETHING, but I don't know
> what.

Well it won't break much. Here's the reason why it was done:

$cvs ann konq_iconviewwidget.cc | grep '\-10'
1.248        (firebaug 02-Aug-03):     QPoint offset(-10,-10);

$cvs log -r1.248 konq_iconviewwidget.cc
revision 1.248
date: 2003/08/02 04:17:39;  author: firebaugh;  state: Exp;  lines: +6 -8
Don't obscure the drag target
===

I can't see the reason for it though, I mean whichever offset is chosen there's always a
chance the dragged icon will obscure the drop target, isn't there?

John, do you see a problem with this offset being turned into 0,0 ?

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).