Fwd: konq_iconviewwidget.cc, what is offset used for?

[David Faure]

This is related to the location of the drag-object hotspot I guess.
Anyone knows if the hotspot changed at some point?

----------  Forwarded Message  ----------

Subject: konq_iconviewwidget.cc, what is offset used for?
Date: Monday 01 March 2004 22:06
From: "Henry W. Miller" <hank at black-hole.com>
To: David Faure <faure at kde.org>


Greetings,

I've been looking at bug 67140, 75478, and 74335.   (duplicates)  when
draging an icon they end up slightly offset from the place where you
droped them.

The attached patch solves the problem, it removes offset from
knoqDragObject.   However I cannot convince myself that someone would have
gone through the effort to put that code in without some goal, so I'm
hesitant to remove it.

Basicly my question is: do I clean this patch up by completely removing
offset from that function.  (assumes that whatever the goal was, it isn't
useful)   Override this function in kdesktop. Or when the icon is droped
undo the offset.   (can be done in kdesktop for sure.  I suspect someplace
else in this file but I'm not sure yet)

-- 
Henry Miller       hank at black-hole.com

-------------------------------------------------------



-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
-------------- next part --------------
Index: konq_iconviewwidget.cc
===================================================================
RCS file: /home/kde/kdebase/libkonq/konq_iconviewwidget.cc,v
retrieving revision 1.277
diff -u -3 -p -r1.277 konq_iconviewwidget.cc
--- konq_iconviewwidget.cc	20 Feb 2004 09:47:27 -0000	1.277
+++ konq_iconviewwidget.cc	1 Mar 2004 20:41:15 -0000
@@ -1127,7 +1127,7 @@ KonqIconDrag * KonqIconViewWidget::konqD
 {
     //kdDebug(1203) << "KonqIconViewWidget::konqDragObject" << endl;
 
-    QPoint offset(-10,-10);
+    QPoint offset(0,0); 
     KonqIconDrag * drag = new KonqIconDrag( dragSource );
     QIconViewItem *primaryItem = currentItem();
     // Append all items to the drag object