[PATCH] When is KHTMLView done with rendering?

[Jeroen Wijnhout]

On Thursday 17 June 2004 15:18, David Faure wrote:
> Small nitpick: why not do the test   if ( !m_url.encodedHtmlRef().isEmpty()
> ) before actually connecting to the signal?
> Then gotoAnchor() will only be called when we actually need to go to an
> anchor, as one might expect.

Done.

> Even more nitpicking: emit finishedLayout() is more common than
> emit(finishedLayout()), since emit isn't a function (merely a noop
> keyword).

Done (just recently learned emit does nothing, old habits die hard...).

> Patch looks great otherwise.

Thanks. If nobody objects I will commit the patch.

best,
Jeroen
-- 
Kile - an Integrated LaTeX Environment for KDE
http://kile.sourceforge.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: khtml_anchor_bug.diff
Type: text/x-diff
Size: 4385 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20040617/995d041c/attachment.diff>