PATCH: Bug 58492: downloading dynamic archives impossible

David Faure faure at kde.org
Mon Jun 14 00:30:31 BST 2004


On Sunday 13 June 2004 22:02, Thiago Macieira wrote:
> Dawit A. wrote:
> >Hi,
> >
> >Here is another patch for kio_ftp to address BR#58492. I do not why
> > there is a need to do a SIZE command in ftpGet before attempting to
> > retreive the resource instead of simply doing the GET and letting it
> > fail. Anyways, the patch simply adds a config option to skip the
> > ftpSize stuff when doing a GET. The nice thing about doing it this
> > way is that the option can be enabled per site...
> 
> I'd let the SIZE command be issued in any case, but instead I wouldn't 
> rely on its value to indicate the presence of the file.
> 
> Let GET fail when that happens. If SIZE returns a size, we'll be able to 
> show it in the download window and estimate time. If it doesn't, try 
> and retrieve the file nonetheless.

Yes. Fix the bug, don't add an option to workaround it :)

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kfm-devel mailing list