[PATCH] Last version of the "fix label form focus" (59489)

[bj at altern.org]

Hi!

> I looked at your patch, and though I'm not really fluent with the event
> handling mechanism, there are things that bother me:
> - first: indentation is crappy, please fix it to match the code style :-)
> - you seem to short-circuit totally the DOM events with your activateInput
> ...it should really be a click()
> - your reimplementation of defaultEventHandler looks wrong too
>   -> does not call the base class (how will it handle other events then)
>   -> does not mark the event as defaultHandled
>
> eventually, I wonder if your activateInput isn't just turning around a
> shortcoming in HTMLInputElementImpl::defaultEventHandler when receiving  a
> CLICK_EVENT without a previous MOUSE_UP

Most problems corrected in this new patch. You were right about the 
CLICK_EVENT without a MOUSE_UP event. So I changed the 
HTMLInputElementImpl::defaultEventHandler to react on CLICK_EVENT rather than 
on MOUSE_UP event. Could'nt find any side effect, but maybe someone can give 
me a reason why it is better to use MOUSE_UP...

Otherwise, it is much cleaner now. OK?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: forms.diff
Type: text/x-diff
Size: 4062 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20040707/eb6fdd3b/attachment.diff>