[PATCH] Last version of the "fix label form focus" (59489)

Germain Garand germain at ebooksfrance.org
Tue Jul 6 16:01:05 BST 2004


Le Mardi 06 Juillet 2004 13:58, bj at altern.org a écrit :
> Let's hope that if more browser support the label form focus, webmasters
> will become more careful with the <label> tag.
>
> By the way, shall I get somebody else's approval before committing my patch
> ?

I looked at your patch, and though I'm not really fluent with the event 
handling mechanism, there are things that bother me:
- first: indentation is crappy, please fix it to match the code style :-)
- you seem to short-circuit totally the DOM events with your activateInput
...it should really be a click()
- your reimplementation of defaultEventHandler looks wrong too
  -> does not call the base class (how will it handle other events then)
  -> does not mark the event as defaultHandled

eventually, I wonder if your activateInput isn't just turning around a 
shortcoming in HTMLInputElementImpl::defaultEventHandler when receiving  a 
CLICK_EVENT without a previous MOUSE_UP

Greetings,
Germain





More information about the kfm-devel mailing list