[PATH] Improve icons layout

[Benoit Walter]

Thanks for the comment, updated patch removes the added members in KFileIVI. 
The previewIconSize function is fast enough, so it shouldn't have any effect 
on performance. I also removed m_canPreview which was actually not needed.


On Tuesday 20 January 2004 19:57, David Faure wrote:
> I can't really comment on the rest of the patch, but the above seems to eat
> quite some memory unnecessarily. This is for each item - and in some
> directories there can be many many items, so better not enlarge KFileIVI if
> not needed.
>
> m_iconView is already stored in QIconViewItem, just cast iconView()
> to a KonqIconViewWidget * like we already do in kfileivi.cc
>
> m_canPreview is ok (it fits with the other bool, no size increase)
>
> m_thumbSize can apparently be removed and always recalculated on the fly
> as iconview->previewIconSize( size ), unless that's too slow.
>
> Thanks for taking into account the memory consumption issue.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libkonq2.diff
Type: text/x-diff
Size: 19054 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20040120/ec9cc252/attachment.diff>