ecma/kjs_window.cpp Window::goURL

Sat Jan 10 21:49:15 GMT 2004

On Sat, Jan 10, 2004 at 10:32:58PM +0100, David Faure wrote:
> On Saturday 10 January 2004 21:32, Koos Vriezen wrote:
> > Hi,
> > 
> > Window::goURL does not do 'location.href = location.href' for a reload. Couldn't
> > find where this was added in the cvs logs, but
> > // Check if the URL is the current one. No [infinite] redirect in that case
> > suggest it fixes something, but it breaks "Luister Live" on http://www.radio1.be.
> > (See #72304 for the application)
> 
> cvs ann -r1.286 kjs_window.cpp | grep infinite
> 1.270        (faure    30-Jul-02):           // Check if the URL is the current one. No [infinite] redirect in that case.
> 
> cvs log -r1.270 kjs_window.cpp
> Fix for location='url', infinitely looping on https://start.telebank.co.il

Fix breaks compatibility with other browsers

<html><body onLoad='alert("hi")' onClick='location.href=location.href'></body></html>

see the difference with mozilla (and most probably ie too)  and konqueror.

Indeed mozilla hangs on
<html><body onLoad='location.href=location.href'></body></html>
but konqueror doesn't make much of https://start.telebank.co.il either ...

Anyway, we can't ignore side effects of eg cookies and assume reopening the same
url is pointless.

Koos