[Patch] fix for d->postponed_autorepeat leak under caret mode

David Faure dfaure at klaralvdalens-datakonsult.se
Thu Jan 8 20:07:53 GMT 2004


On Thursday 08 January 2004 21:06, Leo Savernik wrote:
> Hello,
> 
> khtml leaks QKeyEvent objects, which stem from d->postponed_autorepeat in
> combination with caret mode. Assertions are triggered all over the place when
> activating caret mode and pressing (and holding) any arrow key.
> 
> This patch correctly frees the QKeyEvent objects, but I'm not sure if it
> doesn't break something.
> 
> Can somebody more intimate with d->postponed_autorepeat comment on the patch?

If you eat/redirect all keypress events to a special method, in caret mode,
why don't you do the same with keyrelease events?

Calling the "normal case" code for keyreleases but not for keypresses is asking for trouble :)

-- 
David Faure -- faure at kde.org, dfaure at klaralvdalens-datakonsult.se
Qt/KDE/KOffice developer
Klarälvdalens Datakonsult AB, Platform-independent software solutions




More information about the kfm-devel mailing list