[patch] fix for bug 68181

Tue Jan 6 15:00:24 GMT 2004

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le Sunday 28 December 2003 16:05, Waldo Bastian a écrit :
> The following HTML fails to show test.png:
> > <html>
> > <head>
> > <link rel="stylesheet" href="test.png" />
> > <title>1</title>
> > <body>
> > <img src="test.png" alt="don't mind" />
> > </body>

Le Sunday 28 December 2003 21:02, Waldo Bastian a écrit :
> On Sun December 28 2003 18:56, Luís Pedro Coelho wrote:
> > I will write some code for the different cachespaces solution, though.
>
> Great.

After a long delay (I took a holiday last week and didn't manage to finish it 
before), here is the patch.

A few comments:

 - I think it works. konqueror has ran an hour on it now. It also shows the 
above testcase alright. Konqueror has crashed once or twice, but from the 
backtraces I don't think it's related (the rest of KDE is compiling in the 
background as well, so its a mixed this-week/last-week system right now).

 - I did different cache-spaces instead of different caches bc it meant less 
changes in the code.
I think different caches might be cleaner (and safer : no way you can make a 
mistake and get the wrong type). Also it would simplify the loops on the 
images which now skip undesired objects based on type, for example. Still, a 
lot of things would need to be revised and I don't know the code well enough.

- - I changed the DocLoader::needReload function (and the meaning/name of 
m_reloadedURLs) as well. It is a different class, but since these classes are 
all internal and friends of each other, I think it's not unclean if changing 
one, requires changing another.

- - This reverts my earlier fix. If the namespace are independent, then the 
types are garanteed to be correct, except on a serious bug, so an assert() on 
the types is fine.

So, what do you think?
- -- 
Luis Pedro Coelho

On user interfaces and languages, see:
http://luispedro.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE/+s2MGpBAvyRwXdgRAgSBAKCSpz3w7WBEBYaRhmtByQoWcRg1eQCfVZ2w
V6wT/CEKm2hxmJ8s1UZTE0k=
=YXxM
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kmail-attach.cxwT4k
Type: text/x-diff
Size: 8095 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20040106/6f470b8f/attachment.diff>