patch: khtmlimage

[David Faure]

On Monday 05 January 2004 21:01, Simon Hausmann wrote:
> Hi,
> 
> Currently when viewing an image with khtmlimage and changing for example the 
> active tab (or frame) and then switching back the pretty image caption ('Blah 
> Type Image - 123x456 Pixels') is lost. The attached patch fixes this bug.

Looks good.

> Ideally I'd rather like to get rid of the current 
> ReadOnlyPart::guiActivateEvent implementation (as nowadays konq 
> saves/restores the caption properly) , but I'm not sure if changing that 
> behaviour is a good thing to do so late, so this patch kind of works around 
> this base implementation by simply not calling it in the particular case 
> (which apparently doesn't hurt as KHTMLPart doesn't do it either :)

Hmm, I can't remember the way things changed over time.
Initially it was guiActivateEvent's task to set the caption, indeed....
Konq stores it, but in theory other "hosts" might not... so I agree with not changing this.

-- 
David Faure -- faure at kde.org, dfaure at klaralvdalens-datakonsult.se
Qt/KDE/KOffice developer
Klarälvdalens Datakonsult AB, Platform-independent software solutions