navigator.plugins and kparts for konqueror

[David Faure]

On Friday 13 February 2004 16:09, Koos Vriezen wrote:
> On Fri, Feb 13, 2004 at 03:58:39PM +0100, David Faure wrote:
> > On Friday 13 February 2004 15:52, Koos Vriezen wrote:
> > > On Fri, Feb 13, 2004 at 11:31:21AM +0100, Koos Vriezen wrote:
> > > > A bug was entered for kmplayer http://bugs.kde.org/show_bug.cgi?id=75108
> > > > and it's about a page
> > > > http://www-306.ibm.com/e-business/doc/content/ondemand/tvspot.html
> > > > that uses navigator.plugins to determine if a certain movie player is
> > > > installed (see http://www-306.ibm.com/e-business/doc/content/ondemand/popups.js)
> > > > Currently ecma/kjs_navigator.cpp only looks in
> > > > .kde/share/apps/nsplugins/pluginsinfo for that array, not including
> > > > plugins like kjas and kmplayer (unacceptable of course :-).
> > > > So what we could do is assign a rc or directory for it in share/apps/khtml,
> > > > or return an array of all registered mime types that have an embedded app
> > > > assigned...actually I like the last option.
> > > 
> > > Rob Buis pointed me to a patch he posted in Oct last year and it does
> > > pretty much the above. I changed it a little bit, less kdebug, strip original
> > > nsplugin config stuff and no special case for inode.
> > 
> > I like this patch - but I think the config stuff should remain. The idea was that if you disable
> > plugins in "Configure Konqueror" (assuming this really means all plugins, not just nsplugins),
> > then navigator.plugins shouldn't return anything, otherwise the site will think you have plugins.
> 
> Ah, yes there a two configs, the 'enable plugins' and the reading of nsplugins/pluginsinfo
> Indeed only the second can be stripped.

Looks fine now (although the "// FIXME: add domain support here" comment should remain too).
:) 

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).