Bug: Detach Tabs loses history

[Daniel Teske]

Hi

eh, my mailer can't read my mind.  
So here is the patch and a correct explanation why this patch is
correct.

KonqViewManager::breakOffTab() creates a new Window (mainWindow)
and calls:
mainWindow->viewManager()->loadViewProfile( config, "" );
which always calls:
convertDocContainer();

convertDocContainer() sets:
m_pDocContainer and m_pChildFrame to new KonqFrameTabs()

So after loadViewProfile()
m_pDocContainer is of type Tabs and
m_pDocContainer == m_pChildFrame.

which means that:
mainWindow->viewManager()->setDocContainer( mainWindow->childFrame() );
is reduant.

But as the code is complex, and I don't understand every bit of it, I
put some safeguards around my code.

kft->childFrameList()->at(0)->copyHistory( currentFrame );
means copy the history of the breaked off tab into the first tab of the
new window. (Because the window is new, it ought to have only one tab.)

daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: breakoff-tab-patch
Type: text/x-patch
Size: 849 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20041223/3229186c/attachment.bin>