[patch] #57080: fix unnecessary scrollbars

[Germain Garand]

Le Jeudi 12 Août 2004 18:45, Leo Savernik a écrit :
> Am Donnerstag 12 August 2004 19:09 schrieb Germain Garand:
> [...]
>
> > I was speaking of #57080 :-)
> > Gimme da patch :-)
>
> D'oh, I misread the message. Well here it is:
> http://bugs.kde.org/attachment.cgi?id=7090&action=view
>
> The patch introduces two methods RenderObject::renderedWidth and
> RenderObject::renderedHeight, which return the extents that have to be
> considered for rendering. Safari uses overflowWidth/Height with a parameter
> instead, but I'm not quite persuaded that this is the better way.

entirely agreed. Those confusing bool, changing method behaviours in random 
ways are a plague.
What would you say of effectiveWidth/Height instead of renderedWidth/Height?

Also, it should either be virtual or read 
    return !hasOverflowClip() && isRenderBlock() ? overflowHeight() : 
height();
otherwise you'll have 0 on non-blocks, me think.

>
> The repaintRectangle methods make now use of renderedWidth/Height.
>
> RenderCanvas::docWidth/Height are rewritten to use renderedWidth/Height,
> and only use the width/height of the canvas' layer, not its children (as
> they may be located within an hasOverflowClipped-element, and thus do not
> contribute to the final dimensions).

looks all fine.
will test it shortly.

Greetings,
Germain