[patch] #57080: fix unnecessary scrollbars

Leo Savernik l.savernik at aon.at
Thu Aug 12 18:45:27 BST 2004


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Donnerstag 12 August 2004 19:09 schrieb Germain Garand:
[...]
> I was speaking of #57080 :-)
> Gimme da patch :-)

D'oh, I misread the message. Well here it is:
http://bugs.kde.org/attachment.cgi?id=7090&action=view

The patch introduces two methods RenderObject::renderedWidth and 
RenderObject::renderedHeight, which return the extents that have to be 
considered for rendering. Safari uses overflowWidth/Height with a parameter 
instead, but I'm not quite persuaded that this is the better way.

The repaintRectangle methods make now use of renderedWidth/Height.

RenderCanvas::docWidth/Height are rewritten to use renderedWidth/Height, and 
only use the width/height of the canvas' layer, not its children (as they may 
be located within an hasOverflowClipped-element, and thus do not contribute 
to the final dimensions).

It fixes the following regressions:
unsorted/RESOLVED-43426-355.html
webcore/fast/clip/014.html
webcore/fast/flexbox/009.html
webcore/fast/overflow/006.html

It causes regressions (but doesn't seem to be bad):
webcore/fast/block/positioning/auto/007.html

Changes to rendering tree (but not the rendering itself):
webcore/fast/encoding/utf-16-big-endian.html
webcore/fast/encoding/utf-16-little-endian.html

Please review. I'll commit to head and backport as soon as KDE_3_3_0_RELEASE 
is tagged.

mfg
	Leo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQFBG6y4j5jssenUYTsRAowbAJ9U2MMuh1+mgrU8NEYqhq0XWxbd/QCeOgLN
K0Rf8qVjD7NT7HVCVfQ4EH4=
=j3+K
-----END PGP SIGNATURE-----




More information about the kfm-devel mailing list