change in checkselection

Leo Savernik l.savernik at aon.at
Mon Sep 8 22:29:37 BST 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

Now that I'm forced to recompile all of my local KDE, I've got plenty of time 
to present the following patch for review.

It's a minor change in RenderText::checkSelection which is part of an attempt 
to make clicks into the view put the caret at much more predictable 
locations. That means a click in front of a line should put the caret in 
front of the line (and never at the end of the previous line, as khtml's 
existing implementation does sometimes).

The essence is treating SelectionPointBeforeInline like SelectionPointInside, 
and *not* like SelectionPointBefore.

However, there may be a cause why the old behaviour was implemented the way it 
is that I'm not aware of. So if there is one, I'd like to hear about it 
(otherwise I'll commit).

mfg
	Leo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE/XPTIj5jssenUYTsRAtOtAJ9IXJQg83dT6zJD8E2vPJKRBSTL5wCfdBrN
S/Zt8bCqii3iRxxGiUxCefI=
=cXZV
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: khtml_navigation_23a.diff
Type: text/x-diff
Size: 1322 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20030908/93d1604d/attachment.diff>


More information about the kfm-devel mailing list