[patch] working out namespaces/css issues (was xml+css borken in head)

Germain Garand germain at ebooksfrance.org
Sat Oct 25 19:07:39 BST 2003


Le Samedi 25 Octobre 2003 17:49, David Faure a écrit :
@@ -1618,27 +1623,27 @@ NodeImpl::Id DocumentImpl::getId( NodeIm
     NodeImpl::Id id = 0;
     QConstString n(_name->s, _name->l);
     bool cs = true; // case sensitive
-    if (_type != NodeImpl::NamespaceId) {
+    // Do those hacks only for attributes. Keep everything clean for 
elements,
+    // it's all handled in createElement*
+    if (_type == NodeImpl::AttributeId) {
         // Each document maintains a mapping of tag name -> id for every tag 
name encountered
         // in the document.
         cs = (htmlMode() == XHtml);
         // First see if it's a HTML element name


mmhh... I see one problem here though : you are skipping the lookup in the 
standard tag hash for elements... yet the css parser does a getId lookup for 
each new element and thus will fail to identify standard tags.
Should it first do a getTagName, then a getId? (i.e. do you think getId should 
only lookup for non-preregistered elements?)




More information about the kfm-devel mailing list