Patch for bug 62672: Tree view rooted at devices:/ malfunctions

[David Faure]

On Friday 10 October 2003 12:55, Wilco Greven wrote:
> Hi,
> 
> Below is a patch which should fix bug 62672. Items in redirected subdirs where 
> listed at the toplevel because the treeview doesn't handle the redirection 
> correctly. When a redirection happens a clear(url) signal is sent first by 
> the dirlister. The treeview handled the clear signal by removing the entire 
> directory instead of clearing it. 
> The patch fixes this by splitting up the removeSubDir method in a clearSubDir 
> method and a smaller removeSubDir method which calls clearSubDir. 
> One thing I'm not sure about is whether the directory should be removed from 
> m_urlsToOpen and m_urlsToReload in the clear or the remove method.

Can't remember what m_urlsToReload is used for.

m_urlsToOpen is for restoring the opened/closed state of the treeview,
when going back/forward in history; if we assume the redirection from A to B
always happens, one can't have A in the history anyway, so it can't
be in m_urlsToOpen AFAICS (so this doesn't matter much where it's done).

> Bug report: http://bugs.kde.org/show_bug.cgi?id=62672
> 
> Ok to commit?

Please do.
Thanks.

-- 
David Faure -- faure at kde.org, dfaure at klaralvdalens-datakonsult.se
Qt/KDE/KOffice developer
Klarälvdalens Datakonsult AB, Platform-independent software solutions