khtml 3.1.2 has trouble with <frame src="">

Koos Vriezen koos.vriezen at xs4all.nl
Tue May 20 13:09:01 BST 2003


Hi,

This doesn work properly (wheel keeps spinning, no way to set the
frame.location.href attribute from js)
 <html> <frameset>
  <frame SRC="">
 </frameset></html>

Shouldn't src="" be treated as src="about:blank" like
--- khtml_part.cpp-orig Tue May 20 13:55:16 2003
+++ khtml_part.cpp      Tue May 20 13:55:30 2003
@@ -3207,7 +3207,7 @@
   if ( child->m_extension )
     child->m_extension->setURLArgs( child->m_args );

-  if(url.protocol() == "javascript" || url.url() == "about:blank") {
+  if(url.protocol() == "javascript" || url.url() == "about:blank" || url.isEmpty()) {
       if (!child->m_part->inherits("KHTMLPart"))
           return false;

@@ -3226,13 +3226,11 @@
       p->end();
       return true;
   }
-  else if ( !url.isEmpty() )
+  else
   {
       //kdDebug( 6050 ) << "opening " << url.url() << " in frame " << child->m_part << endl;
       return child->m_part->openURL( url );
   }
-  else
-      return true;
 }
? (patch against khtml-3.1.2)

Koos




More information about the kfm-devel mailing list