[PATCH] Konq: resize on removeView (sidebar size problem)

David Faure dfaure at trolltech.com
Sun Jun 8 14:44:16 BST 2003


On Sunday 08 June 2003 15:38, Waldo Bastian wrote:
> When removing a view from a split view, Konqy switches back to an unsplit
> view. It reparents the remaining view out of the QSplitter
> (KonqFrameContainer). The view that is about to be deleted remains in the
> QSplitter. QSplitter automatically updates the layout, causing the to be
> deleted view to be resized to the full width.
> 
> The sidebar saves it's width when it gets destructed and as a result saves
> this full width, instead of the width it had before the other view got
> removed from the Qplitter.

Good catch!

> The attached patch makes that KonqFrameContainer (QSplitter) doesn't do any
> layout changes any more when it is about to get deleted anyway. This is
> slightly faster and allows the sidebar to save its width properly.

Looks ok, except that I'd call the method setAboutToBeDeleted(), otherwise
it looks like an accessor (that returns the value).

Thanks a lot,
David.

-- 
David FAURE, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
Qtella users - stability patches at http://blackie.dk/~dfaure/qtella.html




More information about the kfm-devel mailing list