[PATCH] JS Form Popups

[Ralf Hoelzer]

Thanks for your comments. I gave it another shot :). The new patch is 
attached. 

> wonder if the message shouldn't be a bit different, to explain that
> answering "no" will NOT submit the form? It's a bit different from "no
> popups please" - here the form will not be posted, which in some cases is
> much worse than the resulting popup...

You are right, the wording should mention this is a form submission. I changed 
that. I guess this gives the KMessageBox code a right to be there now.

> Maybe it would also be clearer (and safer) if the if() that tests the
> windowopenpolicy was the very first thing, around all this. Just to make
> sure we don't affect the behaviour in the other cases due to some mistake
> in this code (in the future :).

All the checks are now only done, if the policy is not "allow".

> As I see it the logic should be:
> if ( policy is to ask )
> {
>  do all checks to see if we need to ask;
>   if (we need to ask) {
>      ask();
>       -> if the user chose no, return.
>   }
> }
> submit.   << the only call to submit, in fact.

This is pretty much how I've done it now, with the only difference that it 
distinguishes between "ask" and "smart/deny".

regards,
Ralf

-------------- next part --------------
A non-text attachment was scrubbed...
Name: popup2.patch
Type: text/x-diff
Size: 2498 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20030604/d382a410/attachment.patch>