[PATCH] dom_string valgrinf warning

Dirk Mueller mueller at kde.org
Fri Jul 4 10:36:18 BST 2003


On Don, 03 Jul 2003, Luciano Montanaro wrote:

> +    if ( l != bs.length() ) return true;
>      int l = as.length();

Did you even compile it or check if your patch fixes anything? Which 
compiler accepts undeclared variables?

Furthermore, when I look at the code, I see this in the very first line of 
the method:

bool DOM::strcasecmp( const DOMString &as, const DOMString &bs )
{
    if ( as.length() != bs.length() ) return true;



-- 
Dirk




More information about the kfm-devel mailing list