Regression of KHTML's smart popup feature

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

(following up on the right list)
On Saturday 25 January 2003 02:08, Dawit A. wrote:
> Hi,
> 
> I traced the cause for BR# 52720, 52902 and 53377 to a recent commit to both 
> the HEAD and KDE_3_1 branches that replaced CLICK_EVENT with 
> KHTML_ECMA_CLICK_EVENT to "make khtml's event handling suck a little less." 
> See -r 1.50 khtml/ecma/kjs_binding.cpp.  Unfortunately, the replacement event 
> does not seem to be emitted whenever an onClick event is generated.  Instead 
> the event that reaches the javascript interpreter is still CLICK_EVENT.  This 
> causes ScriptInterpreter::isWindowOpenAllowed() to always fail and hence 
> break the smart popup feature. Can one of the khtml/kjs hackers more familiar 
> with the code, please look into this ?  Specially the person that broke it :)

Hmm, so s/KHTML_ECMA_CLICK_EVENT/CLICK_EVENT/ (in kjs_binding.cpp)
fixes it, right?

- -- 
David Faure -- faure at kde.org, dfaure at klaralvdalens-datakonsult.se
Klarälvdalens Datakonsult AB, Platform-independent software solutions
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice-1.2.1 is available - http://download.kde.org/stable/koffice-1.2.1/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE+M7jv72KcVAmwbhARAkF+AJ97M0oLkG7YLCLhEl8mOONxMRLGvgCeIKoU
sKj9x+AghuDFffvwCvRBwtM=
=YLSs
-----END PGP SIGNATURE-----