[PATCH] Improve selecte Set Encoding (Automatic Detection for Japanese)

[Toshitaka Fujioka]

On Monday 20 January 2003 23:08, David Faure wrote:
> On Sunday 19 January 2003 15:25, Toshitaka Fujioka wrote:
> > I attached a new patch.
>
> +    else if ( name.lower() == "cp1250" || name.lower() == "ibm852" ||
> name.lower() == "iso-8859-2" || name.lower() == "iso-8859-3" ) { +     
> language = khtml::Decoder::CentralEuropean;
> +    }
> +    else if ( name.lower() == "cp1251" || name.lower() == "koi8-r" ||
> name.lower() == "iso-8859-5" ) { +      language = khtml::Decoder::Russian;
> +    }
> etc.
>
> Very slow - you're transforming name to lowercase 20 times.
> Use name = name.lower(); on top, so that it's done only once.

You're right. Thanks !!
I attached a new patch. Please review.

Regards,
Toshitaka


-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdelibs-khtnl-improve-selectSetEncoding-20030125.diff
Type: text/x-diff
Size: 22406 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20030125/ad81a3a9/attachment.diff>